[FFmpeg-devel] [PATCH] [ISSUE 793] Fix mp3 identification regressions

Michael Niedermayer michaelni
Fri Jan 30 22:46:41 CET 2009

On Thu, Jan 29, 2009 at 12:31:52PM -0500, Alex Converse wrote:
> On Thu, Jan 29, 2009 at 12:28 PM, Alex Converse <alex.converse at gmail.com>wrote:
> > Right now MP3 files with ID3v2 tags bigger than 2MB no longer identify as
> > MP3. This patch makes the mp3 probe return 1 on files with id3v2 tags where
> > mp3 was not identified to make these files identiy as MP3 on the last probe
> > pass. A more elegant solution would be for the probes to be able to request
> > seeking, however it seems that that would piss all over the API. I know
> > Michael had suggested a return value to request more data in general but in
> > theory ID3v2 can grow over 256 MB and I'm nto sure we'd want to sent that
> > much information to the probe.
> >
> I suppose it might be helpful if I actually attach the patch.

iam not against this patch id just like to make sure you understand that
it will not be nearly as reliably as you might think, other codecs also
make wild guesses and return 1 on random data on occasion

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/de45dc4a/attachment.pgp>

More information about the ffmpeg-devel mailing list