[FFmpeg-devel] [PATCH] Gopher client support

Michael Niedermayer michaelni
Sat Jan 31 00:56:26 CET 2009


On Sun, Jan 25, 2009 at 01:33:48PM +0900, nazo wrote:
[...]
> attached new patch

[...]

> +/* used only when posting data */
> +static int gopher_write(URLContext *h, uint8_t *buf, int size)
> +{

comment is not doxygen compatible

[...]
> +/**
> + * Open gopher URI handle via TCP
> + * @param h media file context
> + * @param uri of the remote server
> + * @returns 0 if OK, AVERROR_xxx otherwise
> + */
> +static int gopher_open_cnx(URLContext *h, const char *uri)

this is called just from one point and thus doesnt need to be in its
own function unless you plan to add some further calls to it in the
future?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090131/ccedcce2/attachment.pgp>



More information about the ffmpeg-devel mailing list