[FFmpeg-devel] [PATCH] RTSP-MS 8/15: fix RTSP-MS UDP (was: disallow UDP/RTSP-MS)

Ronald S. Bultje rsbultje
Sat Jan 31 18:23:24 CET 2009


Hi,

On Sun, Jan 25, 2009 at 2:14 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Tue, Jan 6, 2009 at 12:07 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> I haven't gotten UDP/RTSP-MS to work yet, so this patch explicitely
>> disallows anything else than TCP/RTSP-MS.
>
> Attached patch fixes this, I think. Negotiation succeeds, the data is
> slightly different than for TCP but that will be handled in a
> different patch.
>
> The patch is dirty, in a way, because for UDP in RTSP-MS:
> - the server expects the RTX stream to be SETUP'ed first, even if it's
> not the first in the SDP. (For TCP, we ignore the RTX.)
> - right now I create a RTSPStream+AVStream pair for the RTX stream. I
> could in theory just create a AVStream-less RTSPStream since the
> client doesn't need this, it's just for the session.
> - we should use two ports for the RTX, and then the next (one) for all
> data streams, so:
>
> SETUP x.y.z/x.asf/rtx
> Transport: client_port=[x]-[x+1]
>
> OK
>
> SETUP x.y.z/x.asf/stream=1
> Transport: client_port=[x+2]
>
> OK
>
> SETUP x.y.z/x.asf/stream=2
> Transport: client_port=[x+2]
>
> OK
>
> (etc. for stream=3-n)
>
> This is what wireshark dumps of MS sessions give me and it works, so I
> kept it simple for now. I tried different orders or port numbers but
> it all fails at the second or third SETUP with either a 500 (Internal
> Server Error) or a 461 (Unsupported Transport).

Ping, someone wants to review the patch?

Ronald




More information about the ffmpeg-devel mailing list