[FFmpeg-devel] [PATCH] clamp theora filter_limit_values

Michael Niedermayer michaelni
Sun Jul 5 19:29:12 CEST 2009


On Sun, Jul 05, 2009 at 11:36:36AM +0200, Reimar D?ffinger wrote:
> On Sun, Jul 05, 2009 at 04:29:44AM -0400, David Conrad wrote:
> > On Jul 5, 2009, at 4:04 AM, Reimar D?ffinger wrote:
> > > this fixes a out-of-bounds write in init_loop_filter with
> > > ogv/smclock.ogv.1.84.ogv from issue 1240.
> > > My patch would just limit the filter limit values read from the file  
> > > to 64,
> > > which avoids the issue. If larger values are allowed, e.g. the size of
> > > the bounding_values_array would have to be increased.
> > 
> > Larger values are allowed IIRC, the max being 127.
> 
> I have some doubts about the visual usefulness of those values, but I
> guess this variant is more correct then.

>  vp3.c |   18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 136aa39584b1bd08690b44254a23e421ff79d2a7  vp3filt.diff

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090705/8f64e69a/attachment.pgp>



More information about the ffmpeg-devel mailing list