[FFmpeg-devel] [PATCH] 4 of 5 Add Speex Encoding
Tue Jul 7 00:57:32 CEST 2009
On 07/06/2009 03:46 PM, Art Clarke wrote:
>> Like this in Justin's patch ?
>> + bytestream_put_buffer(&p, avctx->extradata, SPEEX_HEADER_SIZE);
>> Your patch duplicates the comment part.
> I missed that. Let me restate: Justin gets it right.
>> Justin had some concerns about overhead in ogg files, don't you have these
>> concerns ?
> Yes and no.
> Yes, there is a lot of overhead per packet if you put one speex frame per
> ogg packet.
> But no, because our current patch just chooses 2 as the # of frames per
> packet. Why? Adobe in their infinite wisdom decided to make 2 frames per
> packet be the default in their Flash Player client-side Speex encoders, and
> so we need our encoder to match that by default. If we want to (and we do)
> encode speex streams we can send to flash players, we need some way to make
> that configurable (best case), or hard-code it to 2 (what we did for now).
> See the comments in my first patch about how it'd be nice to have that be
> configurable (I just don't know what setting in AVCodecContext if any to
> use). I think Justin and I are sniffing at the same general problem -- and
> I'll accept guidance on what (if anything) y'all want to do. Either comment
> on my patches and I'll keep tweaking them, or Justin, you can use my patches
> as learnings for the ultimate speex encoding solution deployed in FFmpeg.
Well thanks for the information.
I have ok'd Justin's patch, so he can apply it whenever he wants. I
might apply it soon also.
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer http://www.ffmpeg.org
More information about the ffmpeg-devel