[FFmpeg-devel] [PATCH] qtrleenc: Add RGB555 and ARGB pixel formats support

[Michael Niedermayer]

On Wed, Jul 08, 2009 at 11:07:01AM +0200, Alexis Ballier wrote:
> 2009/7/8 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> > Alexis Ballier <alexis.ballier <at> gmail.com> writes:
> >
> >> >> + ? ?case PIX_FMT_ARGB:
> >> >> + ? ? ? ?s->pixel_size = 4;
> >> >> + ? ? ? ?break;
> >> >> ? ? ?default:
> >> >> ? ? ? ? ?av_log(avctx, AV_LOG_ERROR, "Unsupported colorspace.\n");
> >> >> ? ? ? ? ?break;
> >> >
> >> > unrelated?
> >>
> >> sorry but I don't understand; setting pixel_size to the correct value
> >> is needed by the rest of the encoder.
> >
> > You are expected to send two patches: One that fixes pixel_size for
> > PIX_FMT_ARGB, one that adds RGB555 support.
> 
> The fact is that no part of the original patch was fixing anything,
> only adding support for new pixel formats. The addition of both
> formats was so similar and trivial that i didn't think it was worth
> two different patches.
> Anyway, here is a patch for argb since it'll probably be easier to
> work on rgb555 if this is merged first.

patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090708/92100b62/attachment.pgp>