[FFmpeg-devel] [PATCH] Add SHA-2

[Ronald S. Bultje]

Hi,

On Wed, Jul 8, 2009 at 2:43 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Wed, Jul 08, 2009 at 06:50:10PM +0300, Kostya wrote:
>> On Wed, Jul 08, 2009 at 05:25:24PM +0200, Michael Niedermayer wrote:
>> > you cannot rename public headers (without a major version bump)
>> > but iam not in favor of bumping now ...
>>
>> First, this is unused inside FFmpeg (and Google code search shows only two
>> projects which use it).
>> Second, I'm pretty sure that there's no good time to bump major version.
>>
>> Any suggestions on how to get the code in and/or justify major version bump are
>> welcome.
>
> if you really insist then rename the header, it just breaks compilation in a
> fixable way not runtime. But iam not ok with any ABI breaks

$ cat sha1.h
#warning use sha.h
#include "sha.h"
$

And voila, no API breakage.

Ronald