[FFmpeg-devel] [PATCH] Add SHA-2
Thu Jul 9 09:54:18 CEST 2009
On Wed, Jul 08, 2009 at 08:43:43PM +0200, Michael Niedermayer wrote:
> On Wed, Jul 08, 2009 at 06:50:10PM +0300, Kostya wrote:
> > On Wed, Jul 08, 2009 at 05:25:24PM +0200, Michael Niedermayer wrote:
> > > On Wed, Jul 08, 2009 at 07:44:31AM +0300, Kostya wrote:
> > > > I intend to at least try pushing RTMP client before continuing work on
> > > > it, and SHA-2 is used there. That's why this patch is appearing again.
> > > >
> > > > Note: files are renamed to sha.h and sha.c since they will contain code
> > > > for both SHA-1 and SHA-2. Same for functions inside.
> > >
> > [...]
> > > > Index: libavutil/avutil.h
> > > > ===================================================================
> > > > --- libavutil/avutil.h (revision 19141)
> > > > +++ libavutil/avutil.h (working copy)
> > > > @@ -35,7 +35,7 @@
> > > > #define AV_VERSION(a, b, c) AV_VERSION_DOT(a, b, c)
> > > >
> > > > #define LIBAVUTIL_VERSION_MAJOR 50
> > > > -#define LIBAVUTIL_VERSION_MINOR 3
> > > > +#define LIBAVUTIL_VERSION_MINOR 4
> > > > #define LIBAVUTIL_VERSION_MICRO 0
> > > >
> > > > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
> > >
> > > you cannot rename public headers (without a major version bump)
> > > but iam not in favor of bumping now ...
> > First, this is unused inside FFmpeg (and Google code search shows only two
> > projects which use it).
> > Second, I'm pretty sure that there's no good time to bump major version.
> > Any suggestions on how to get the code in and/or justify major version bump are
> > welcome.
> if you really insist then rename the header, it just breaks compilation in a
> fixable way not runtime. But iam not ok with any ABI breaks
OK, what about this compatibility layer?
It adds new SHA functions and is ready to replace old set on major bump.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 20768 bytes
Desc: not available
More information about the ffmpeg-devel