[FFmpeg-devel] Patch: explicitly initialize AVFormatContext *ic = NULL

[Aurelien Jacobs]

On Fri, Jul 10, 2009 at 08:30:35PM -0700, Art Clarke wrote:
> On Fri, Jul 10, 2009 at 7:46 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > if()
> >    av_free()
> > =NULL
> >
> >
> You know, I new about 10 minutes after I sent that patch that would be the
> feedback :)  So I actually put this into our system.

And didn't you expected the following feedback ?

> [...]
> 
> Index: libavformat/utils.c
> ===================================================================
> --- libavformat/utils.c	(revision 19398)
> +++ libavformat/utils.c	(working copy)
> @@ -499,7 +499,9 @@
>      av_freep(&pd->buf);
>      if (pb)
>          url_fclose(pb);
> -    av_freep(ic_ptr);
> +    if (ap && ap->prealloced_context)
> +      av_free(*ic_ptr);

Inconsistent indentation...

Aurel