[FFmpeg-devel] [PATCH] Remove unused variable from videogen.c

Carl Eugen Hoyos cehoyos
Tue Jul 21 00:46:07 CEST 2009


Michael Niedermayer <michaelni <at> gmx.at> writes:

> On Mon, Jul 20, 2009 at 11:44:28PM +0200, Carl Eugen Hoyos wrote:
> > icc reports:
> > tests/videogen.c(203): remark #593: variable "dy" was set but never used
> >       int r, g, b, x, y, i, dx, dy, x1, y1;
> >                                 ^

[...]

> id rather suspect the following
> 
>             x1 = (x << FRAC_BITS) + dx;
>             y1 = (y << FRAC_BITS) + dx;
>                                     ^^
>                             should probably be dy

As you probably expected, this changes all regression tests.

Do you want me to commit the change including the regression test changes?

Carl Eugen






More information about the ffmpeg-devel mailing list