[FFmpeg-devel] [PATCH] Move error codes definitions from lavc to lavu

[Michael Niedermayer]

On Tue, Jul 21, 2009 at 01:54:39AM +0200, Stefano Sabatini wrote:
> On date Monday 2009-07-20 17:24:45 +0200, Michael Niedermayer encoded:
> > On Sun, Jul 19, 2009 at 12:09:16PM +0200, Stefano Sabatini wrote:
> > > Hi, as in subject,
> > > 
> > > this is required if we want for example move the error handling code
> > > to lavu, as it uses it. Also reduces the clutter in avcodec.h.
> > 
> > i am fine with the move in priciple but didnt we want to deprecate the
> > AVERROR_* macros in favor of AVERROR(E*) ?
> 
> What about AVERROR_PATCHWELCOME?

that has no E* so it can stay


> 
> Also how AVERROR(XXX) is better than AVERRROR_XXX?

it needs less code


> 
> Also are we sure mapping A/V multimedia specific errors to POSIX
> errors is a good idea?

Without an alternative suggestion its hard to say ...


> 
> Also how can we say that e.g. -MKTAG('P','A','W','E') doesn't clutter
> with a POSIX error code?

we cannot but it works with all systems for which ive seen E* values
and a clash is exceedingly unlikely (1 in many millions) if a clash
happens we just change it and bump major ver, given the low likeliness
of conflict this seems acceptable to me but i guess some will disagree


> 
> Also the use of the POSIX error codes is arguable (ENOENT is used for
> example when we don't find an option in a context, doxy is "No such
> file or directory"), EILSEQ -> "unknown format", EDOM -> "Number
> syntax expected in filename".
> 

> Also how can we map an error code to an error message?

by writing a function that does that


> 
> All these questions raise the old problem of how to deal more sanely
> with errors in libav*... and since I don't want to get stucked there,

what old problem exactly do you refer to here?
which issue number on roundup is it?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090721/124ee897/attachment.pgp>