[FFmpeg-devel] [PATCH]Remove unused parameter from rotozoom.c

[Michael Niedermayer]

On Wed, Jul 22, 2009 at 02:03:13AM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > -static void gen_image(int num, int w, int h)
> > > +static void gen_image(int w, int h)
> > >  {
> > >    const int c = h_cos [teta];
> > >    const int s = h_sin [teta];
> > 
> > maybe teta should be calcuated from i or passed instead of being a
> > global ...
> 
> Do you mean like this?
> 
> +  const int c = h_cos [num * 360 / DEFAULT_NB_PICT];
> +  const int s = h_sin [num * 360 / DEFAULT_NB_PICT];

i would have thought like:
const int c = h_cos [num % 360];
const int s = h_sin [num % 360];

to keep the checksums from having to be changed again ...


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090722/8ed9c601/attachment.pgp>