[FFmpeg-devel] [PATCH] Move eval.[hc] from lavc to lavu

Stefano Sabatini stefano.sabatini-lala
Sat Jul 25 21:18:03 CEST 2009


On date Monday 2009-07-20 20:01:14 +0200, Michael Niedermayer encoded:
> On Sun, Jul 19, 2009 at 11:44:21AM +0200, Stefano Sabatini wrote:
> > Hi,
> > 
> > there is little point into having eval code in lavc, as it is surely
> > useful when not dealing with codecs, this is also a required steps for
> > the option system re-design.
> 
> i just rejected the re-design, i originally thought you wanted to cleanly
> improve it where deficiencies exist, that is welcome but not a rewrite
> with a random new set of deficiencies ...
> 
> a move of eval to lavu can be considered when there is a clean patch
> that adds nothing but eval support to AVOptions.
> As is its just "old system didnt need it, new system does, let the
> maintainer figure out the rest" you miss here that we first need a
> discussion if we want eval support in options at all ...

I think, apart the usage of eval code in libavcodec/opt.{h,c}, it is
useful to have that features in lavu anyway.

Also note that the current opt.c code already uses eval.c, not only
the new system.

Regards.
-- 
FFmpeg = Free and Funny Maxi Pure EntanGlement



More information about the ffmpeg-devel mailing list