[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

Michael Niedermayer michaelni
Sun Jul 26 22:09:33 CEST 2009


On Sun, Jul 26, 2009 at 03:07:18PM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Sun, Jul 26, 2009 at 1:57 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> > this should probably do more than just silently retunring
> > also
> > 1. please do not use 2 local variable with the name len
> > 2. id write if(len > end - p)
> 
> OK, the function returns 0 on success, <0 on failure (documented), and
> the caller (which has access to a log context and can thus do a nice
> av_log()) will then print a message on failure. I also fixed the other
> two issues you spotted.

iam not maintainer of what remains :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090726/d6fe1b58/attachment.pgp>



More information about the ffmpeg-devel mailing list