[FFmpeg-devel] [PATCH]RTSP Basic Authentication

Ronald S. Bultje rsbultje
Mon Jul 27 23:26:14 CEST 2009


On Mon, Jul 27, 2009 at 5:11 PM, Benoit Fouet<benoit.fouet at free.fr> wrote:
> you can remove the '!= NULL'
> it may just be me, but I would find it easier to read if auth definition
> was at the end of the line.
> 'if (auth[0])' or even 'if (*auth)'
> that would be consistent with how it is initialized in url_split()
> this is never freed
> s/strlen(auth)/auth_len/

Holy shit I suck today. New patch attached that fixes them all. Thanks
for your review. :-).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtsp-auth.patch
Type: text/x-diff
Size: 3086 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090727/2760ac96/attachment.patch>

More information about the ffmpeg-devel mailing list