[FFmpeg-devel] [PATCH] Bluray Subtitle Support, v4

stev391 at exemail.com.au stev391
Tue Jul 28 11:29:50 CEST 2009


On Sat, 2009-07-25 at 10:13 +1000, stev391 at exemail.com.au wrote:
> On Fri, 2009-07-24 at 15:23 +0200, Diego Biurrun wrote:
> > On Fri, Jul 24, 2009 at 05:57:24PM +1000, stev391 at exemail.com.au wrote:
> > > 
> > > Updated patch including Diego's, Aurelien's & Baptiste's comments.
> > > Thanks for the excellent and quick feedback.
> > 
> Thanks again for the comments, I'm glad somebody is interested in my
> patch.
> 
> Updated patch (from v2) to include Diego's & Aurelien's comments.

Updated patch to version 4.

The previous patch kept allocating memory each time a subtitle was
decoded and never freeing the bitmap memory.  This originally was
completed after the subtitle was displayed, however as the start time is
so delayed it meant the subtitle were cleared to early.  Now I free the
memory if it is allocated before allocating the new bitmap size.

Who needs to give the ok for this to be included into FFmpeg?

And once it is Ok'ed can someone commit the patch as I do not have
rights and do not want rights to do this.  I would like to get this
committed so I can then progress with the rare cases that this does not
work on (currently it ignores the subtitle, no crashes/hangs etc after
watching several movies with subtitles on) and try and work out why they
are delayed.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bluray_subtitles_ffmpeg_19527_v4.diff
Type: text/x-patch
Size: 17280 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090728/4d7c3361/attachment.bin>



More information about the ffmpeg-devel mailing list