[FFmpeg-devel] svq3.c: parse frame size

[Michael Niedermayer]

On Thu, Jul 30, 2009 at 10:12:47AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Jul 30, 2009 at 2:42 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
> > On Wed, Jul 29, 2009 at 12:00:52PM -0400, Ronald S. Bultje wrote:
> >> + ? ? ? ? ? ?if (avctx->width <= 0 || avctx->height <= 0) {
> >
> > why only then?
> 
> The only case where this is relevant (i.e. affects outcome) is that
> where the demuxer gives us one value and the svq3 header gives us
> another. In any other case (if width <= 0, i.e. the demuxer didn't set
> it, or the values are the same) the outcome is the same so it doesn't
> matter.
> 
> OK, so now for that case where svq3 and demuxer tell us something
> different: which do you trust more? My answer was that I trust the
> demuxer more. Why? Well, because this comes from the wiki and is
> relatively untested. I mean, it works for my videos, but it's still
> not as tested as the .mov size parsing code ( :-) ).

i trust the decoder more, please change it to that, it might even fix
some svq3 files, if not and it breaks something this is very easy to
undo and do differently.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090730/811325bf/attachment.pgp>