[FFmpeg-devel] [PATCH] Update x264 asm code to latest version (fixes Win64 issues)

John Adcock dscaler.johnad
Thu Jul 30 23:56:47 CEST 2009


2009/7/30 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Jul 30, 2009 at 05:30:41PM +0100, John Adcock wrote:
>> Attached patch fixes issues using yasm code on Win64 due to different
>> calling convention rules?by updating x264 files to be the same as
>> latest version. ?Win64 patches originally by Anton Mitrofanov.
>>
>> John
>
>> ?fft_mmx.asm ? ? ? ? ? | ? ?2
>> ?h264_deblock_sse2.asm | ? 86 +++++++-------
>> ?h264_idct_sse2.asm ? ?| ? ?2
>> ?x86inc.asm ? ? ? ? ? ?| ?243 ++++++++++++++++++++++++++-------------
>> ?x86util.asm ? ? ? ? ? | ?307 +++++++++++++++++++++++++++++++++++++++++++++++---
>> ?5 files changed, 506 insertions(+), 134 deletions(-)
>> 17d2828435ad3bc6e0d3ec5e6898947b3e1b226f ?win64fixes.patch
>
> if this just updated the files to the latest while presering local changes
> and it has been tested and works then its ok
Apologies, I've noticed I've missed part of the changes to
h264_idct_sse2.asm, I'll send a new patch in the morning.  Also the
changes to fft_mmx.asm and h264_idct_sse2.asm are to supply the
correct parameters to cglobal so that register saving works correctly
and aren't in the x264 code.  Should that be a separate patch?

I've only tested on mingw 32 and 64 bit, would somebody be able to
test the patch on other platforms.

John



More information about the ffmpeg-devel mailing list