[FFmpeg-devel] [PATCH] remove CONFIG_ZLIB checks from lclenc.c
Sun Jun 7 11:55:21 CEST 2009
On Sun, Jun 07, 2009 at 10:34:21AM +0200, Diego Biurrun wrote:
> On Sat, May 30, 2009 at 08:21:04PM +0200, Reimar D?ffinger wrote:
> > currently the lclenc.c code is completely unusable without zlib and also
> > will not be compiled if it is not available.
> > So I propose to remove all those #if CONFIG_ZLIB and just assume it is
> > available.
> > I guess it was done like this to ease adding a mszh or whatever encoder,
> > but this wasn't done the last five years and I have some doubts it would
> > be done in the next 5, and even if I think it is questionable to have
> > them share a file just because they share some code.
> > Any objections?
> Go right ahead, this is what we have done in all other such cases.
> > Btw. I also think that the lcldec.c code might be better using
> > CONFIG_ZLIB_DECODER instead of CONFIG_ZLIB,
> Ummm, it already does...
Yeah, because you're late :-P
> > having code like
> > > if (avctx->codec_id == CODEC_ID_ZLIB)
> > > print an error...
> > when there is no zlib_decoder and thus no decoder registered for
> > CODEC_ID_ZLIB seems like useless bloat and would only "protect" against
> > severe usage errors.
I've already made all those changes, so you don't get to disagree anyway
More information about the ffmpeg-devel