[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 18)

[Michael Niedermayer]

On Tue, Jun 09, 2009 at 08:43:51PM +0200, Cyril Russo wrote:
>
> Michael Niedermayer a ?crit :
>> On Tue, Jun 09, 2009 at 06:19:56PM +0200, Cyril Russo wrote:
>>   
>>> Michael Niedermayer a ?crit :
[...]

>> [...]
>>   
>>> +/** @file + *  This file implements the glue code between FFmpeg's and 
>>> VAAPI's structures.
>>> + */
>>> +
>>>     
>>
>>   
>>> +/** Reconstruct bitstream slice_type. */
>>>     
>>
>> please place the */ on a line of its own, it makes adding
>> more lines later look cleaner in diffs because they dont
>> need to change the first line
>>
>> [...]
>>   
>>> +/** Decoded picture buffer. */
>>>     
>>
>> same thing about */
>>
>>
>> [...]
>>   
>>> +static int append_to_vaapi_decoded_pic_buf(DPB *dpb, Picture *pic)
>>> +{
>>> +    unsigned int i;
>>> +
>>> +    if (dpb->size >= dpb->max_size)
>>> +        return -1;
>>> +
>>> +    for (i = 0; i < dpb->size; i++) {
>>> +        VAPictureH264 * const merged_pic = &dpb->pics[i];
>>> +
>>> +        /* Check if the reference picture was already refered in a 
>>> previous pass */
>>> +        if (merged_pic->picture_id == ff_vaapi_get_surface(pic)) {
>>> +            /* Don't overwrite our reference, use a temporary */
>>> +            VAPictureH264 tmp_pic;
>>>     
>>
>> i still am not happy about calling lavc and VAs pictures pic,
>>   
> I don't get it.
> Everywhere in the file, lavc use "pic".
> Even in the quoted code fragment, pic is lavc, and vapic is anything else 
> (I'm using merged_pic, or va_pic)
> I thought using merged_pic here would be clearer than a unmeaningful va_pic 
> (same for tmp_pic).

so call it merged_va_pic and tmp_va_pic

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090609/083b03d7/attachment.pgp>