[FFmpeg-devel] [PATCH] new av_audio_resample

Michael Niedermayer michaelni
Fri Jun 12 00:37:20 CEST 2009

On Thu, Jun 11, 2009 at 03:14:21PM -0700, Baptiste Coudurier wrote:
> On 6/11/2009 2:58 PM, Michael Niedermayer wrote:
> > On Thu, Jun 11, 2009 at 01:41:59AM -0700, Baptiste Coudurier wrote:
> >> Hi guys,
> >>
> >> I propose to introduce av_audio_resample to add output_size as parameter
> >> since currently using audio_resample there is no way to know the size of
> >> the output buffer.
> > 
> > I hoped we could one day drop resample.c in favor of resample2.c
> > currently resample.c lacking a av prefix is not officially part of the public
> > API your patch would change that
> > 
> > and i belive the API of resample.c is not fit for export, the output_size
> > is surely needed but thats not the only thing, using short types is clearly
> > not correct given the code supports other types, lack of planar audio support
> > in the API also is not good.
> Yes you are right.
> Nobody is inclined to clean it up and reimplement.
> Now we have buggy code causing crashes.

you are right as well

what about adding a 2 at the end instead of a av_ at the begin of the new
function name? that would make me a lot happier with the patch


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090612/67ae9109/attachment.pgp>

More information about the ffmpeg-devel mailing list