[FFmpeg-devel] [PATCH] run level decode function for wma &?wmapro

Sascha Sommer saschasommer
Fri Jun 12 13:47:35 CEST 2009


On Freitag, 12. Juni 2009, Sascha Sommer wrote:
> Hi,
>
> On Freitag, 12. Juni 2009, Michael Niedermayer wrote:
> > On Fri, Jun 12, 2009 at 10:14:15AM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > On Freitag, 12. Juni 2009, Sascha Sommer wrote:
> > > > Hi,
> > > >
> > > > On Donnerstag, 11. Juni 2009, Michael Niedermayer wrote:
> > > > > On Thu, Jun 11, 2009 at 10:17:19PM +0200, Sascha Sommer wrote:
> > > > > > Hi,
> > > > > >
> > > > > > attached patch adds a run level decode function that can be used
> > > > > > for both wma12 and wmapro.
> > > > >
> > > > > could you split it into a patch factorizig the code out and one
> > > > > changing it ?
> > > > > so that code moving around is seperate from functional changes ...
> > > > >
> > > > > [...]
> > > >
> > > > Attached patch factorizes the code out.
> > >
> > > Previous patch used the wrong max_depth for get_vlc2. New patch
> > > attached.
> >
> > oops, i missed that
> > anyway the max_depth has to be a constant, and the bits ideally too
> >
> > [...]
>
> New patch attached. I won't resend the follow up patches.
> Instead, I will update them before the commit once they are approved.
>

And this time, I even updated the doxygen comments...

Regards

Sascha


-------------- next part --------------
A non-text attachment was scrubbed...
Name: shared_wma_rl_decode_try2_splitout4.patch
Type: text/x-diff
Size: 5798 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090612/7c93eb0e/attachment.patch>



More information about the ffmpeg-devel mailing list