[FFmpeg-devel] [PATCH] make packet_size in AVFormatContext unsigned
Mon Jun 15 22:10:24 CEST 2009
On Sun, Jun 14, 2009 at 09:47:49AM -0400, Ronald S. Bultje wrote:
> 2009/6/9 Ronald S. Bultje <rsbultje at gmail.com>:
> > On Tue, Jun 9, 2009 at 5:15 PM, Ronald S. Bultje<rsbultje at gmail.com> wrote:
> >> This will be fun. I think mpegenc.c might have some issues with this
> >> patch, but the best way to "workaround" these is probably not to add
> >> more unsigneds, but rather to set a max. value for the packetsize in
> >> the init() function. Then again, I have no idea what the value of this
> >> limit would be.
> > Same patch, now with correct content-type.
> Ping? I take it that review will take a while (even though really,
> there's just very few using this; most demuxers have their own copy of
> this variable in their structure) - it'd be nice though to get
> confirmed that it's being looked at.
the patch is changing a field to unsiged without you explaining why
or that you verified that all uses of the field are ok with the changed
type. Rather it looks like you expect me to find out if your code is
buggy or not.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel