[FFmpeg-devel] [PATCH] refactor H.264 decoder/parser common code

Michael Niedermayer michaelni
Tue Jun 16 22:48:26 CEST 2009

On Fri, Jun 12, 2009 at 10:50:43PM +0200, Diego Biurrun wrote:
> On Fri, Jun 12, 2009 at 10:49:32PM +0200, Diego Biurrun wrote:
> > This splits off the code shared between parser and decoder into a
> > separate file, similar to what I did for VC-1.  It shrinks h264.c, even
> > if just by about 10%.  It's so huge, every bit counts ;)
> > 
> > There was only one function that I needed to make non-static:
> > free_tables.  I declared it in h264.h as
> > 'void ff_h264_free_tables(H264Context *h);'.
> > 
> > OK to apply?
> Applied.

you meant attached :)

> OK, and now for the non-empty patch...

i think iam not really in favor of this patch, the split is not semantically
sensible IMHO
What i would love to see is to cleanly split parts out and fully document the
API between them
this split does just one thing and that is make it harder to find where
a function is, these are all decoder functions, guessing which is currently
also used by the parser (a thing that likely wil change) is not easy

A similar thing happened to mpegvideo* the split also just made it harder
to find things ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090616/47f66488/attachment.pgp>

More information about the ffmpeg-devel mailing list