[FFmpeg-devel] [PATCH] Fix ffmpeg weird 'Unknown option' error messages

Baptiste Coudurier baptiste.coudurier
Fri Jun 19 07:07:15 CEST 2009

Michael Niedermayer wrote:
> On Wed, May 27, 2009 at 11:37:42PM +0200, Stefano Sabatini wrote:
>> On date Wednesday 2009-05-27 04:01:54 +0200, Michael Niedermayer encoded:
>>> On Tue, May 26, 2009 at 10:13:42PM +0200, Stefano Sabatini wrote:
>>>> On date Tuesday 2009-05-26 03:25:04 +0200, Michael Niedermayer encoded:
>>>>> On Tue, May 26, 2009 at 01:32:44AM +0200, Stefano Sabatini wrote:
>> [...]
>>>>>> Can you see another solution?
>>>>> functions should not print errors that might not be errors to the appliction
>>>> Sorry but this looks like a distorted way of thinking, functions
>>> so you do know of a single function in the standard c lib that does not
>>> follow this statement?
>>>> should print errors when it makes sense, they should be the
>>>> applications to adapt themselves to the library and not vice-versa.
>>>> That said, I'll revert r18826 if there is no better solution for that.
>> So should I revert it?
> if you want

Well, IMHO av_set_string3 is right to print an error if the option does
not exists, it's an error.

So IMHO patch is correct, application should not call it this way.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list