[FFmpeg-devel] [PATCH] [2/2] add the id3v2 parsing for adts aac, take 4

[Diego Biurrun]

On Wed, Jun 17, 2009 at 09:38:45PM +0200, Michael Niedermayer wrote:
> On Wed, Jun 17, 2009 at 09:29:04AM +0200, Patrick Dehne wrote:
> 
> >  id3v1.c |   70 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  id3v1.h |    7 +++++
> >  id3v2.c |   20 ++++++++++++++++
> >  id3v2.h |    5 ++++
> >  mp3.c   |   78 +---------------------------------------------------------------
> >  5 files changed, 104 insertions(+), 76 deletions(-)
> > 58c9a2292b9af5c85b0c78b7f06b7922270a724c  move_id3_reading.patch
> 
> ok

Patch applied (in a short moment).

Now I have to say that your habit of bottom-posting is getting highly
annoying.  It is also counterproductive.

You make it unnecessarily hard for patch monkeys to find approved patches.
I'm very short on time currently and I stopped reading all mails in detail
some time ago.  Now I honestly cannot be bothered to scroll through all
the mails to check if there is an approved patch somewhere.

But I'll gladly use a few minutes of my time to apply approved patches
here and there if I can find them quickly.  This would be the case if
the messages you replied to were suitably trimmed, like I have shown
above.

So if you want to decrease the number of rotting approved patches,
please heed my suggestion.  Thanks a bundle.

> >  raw.c |   23 ++++++++++++++++++++++-
> >  1 file changed, 22 insertions(+), 1 deletion(-)
> > 596c5a2aba1d68e1addca9f0d7f3dcf589b8a3dc  2_adtsaac_parse_id3v2.patch
> 
> left for aac maintainer

ping Rob

Diego