[FFmpeg-devel] [PATCH] Yamaha SMAF decoder supports MA-2/MA-3/MA-5/MA-7

[内田佳久]

Hi,
2009/6/28 Vitor Sessak <vitor1001 at gmail.com>:

>> +        /* Make sure it's followed by an Awa chunk, aka wave data */
>> +        if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
>> +            av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
>> +            return -1;
>> +        }
>>     }
>>  -    /* Make sure it's followed by an Awa chunk, aka wave data */
>> -    if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
>> -        av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
>> -        return -1;
>> -    }
>
> This block has just been reindented. Please do not mix functional and
> indentation/cosmetics changes in patches (even if it will result in a
> temporarily broken indentation) or else they are much harder to review.

The above block is not cosmetic. Patch applied source is following:

} else if (track_chunk == TRACK_CHUNK_PCMAUDIO_TRACK) {
   ...
   /* Make sure it's followed by an Awa chunk, aka wave data */
   if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
      av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
      return -1;
   }
}

Then I think that this block is necessary.

My patch was a little wrong. Then it updates.
changes:
 - For MA-2/MA-3/MA-5, can not decode.
 - References add.

regards,

uchan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg_mmf_decode_2.patch
Type: application/octet-stream
Size: 7926 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090628/6d2bb4bb/attachment.obj>