[FFmpeg-devel] [PATCH] Frame erasure case of pitch delay decoding

Michael Niedermayer michaelni
Mon Jun 29 04:19:48 CEST 2009

On Mon, Jun 29, 2009 at 05:41:48AM +0700, Vladimir Voroshilov wrote:
> If you need any other tests, help me to make them.

iam interrested in a single test, and i thought that was clear
but apparently it was not

The question is which way of handling errors is best
we need to know if my suggestion is better or not
i really wonder what you tested or why

its simple
1. your code
2. my code

which sounds better / has better PSNR for various kinds of realistic errors

Please keep in mind your patch is adding error concealment code, and i must
admit its very light on justification of why its done as is instead of

Also i think it might be better to reject the g729 patchset, the amount of
problems we again have in communiating seem to make a approval practically
Code that looks non optimal needs strong justification not long threads
saying little new.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090629/5d36fe10/attachment.pgp>

More information about the ffmpeg-devel mailing list