[FFmpeg-devel] [PATCH] rtpdec.c: don't overwrite pkt->stream_index in finalize_packet()

Luca Abeni lucabe72
Sun Mar 1 12:11:56 CET 2009

Ronald S. Bultje wrote:
>> As I said, the fact that finalize_packet() is not called for the first
>> packet is a bug that should be fixed... Your last patch makes the code
>> more consistent by introducing the bug in the codepath that is
>> currently correct, but I do not like this kind of consistency ;-)
> How about attached? I removed pkt->stream_index, moved it to the only
> calling place where it is relevant and added finalize_packet() in more
> general places so it is consistently called. It is skipped for

Looks ok. I do not remember when the release is, but if it is near I'd 
suggest to commit this patch after the release.

> I'm thinking it should be skipped for ASF/RM as well, since these are
> container-formats (like MPEG-TS), but don't know how to do that yet.
> Any suggestions?

ASF and RM clearly need a special treatment, and if I understand well 
your code is identifying them based on the fact that they use a dynamic 
payload type... I suspect this is not the best way to address this 
problem (it can create strange interactions with H.264 parsing, for 
example). I suspect that handling ASF and similar in the same codepath 
used for MPEG TS would be simpler (of course it will require some 
changes, but I suspect that in the end the code would look cleaner).


More information about the ffmpeg-devel mailing list