[FFmpeg-devel] [PATCH] Make RM demuxer behave better with -an option

Ronald S. Bultje rsbultje
Sun Mar 1 23:48:18 CET 2009

Hi Kostya,

2009/2/2 Kostya <kostya.shishkov at gmail.com>:
> The story so far:
> ?FFmpeg now has RV30, RV40 (my fault) and AAC (not my fault) support. When
> trying to decode RV40+AAC RM file with -an option video decoder produces
> a lot of garbage and may crash. As I've investigated, that happens because
> with -an option specified RM demuxer begins to feed audio packets to video
> decoder.
> ?With this patch demuxer resets the number of pending audio packets (so they
> won't be demuxed) and skips them (syncing to the next packet header tends to
> produce false positive matches somewhere inside packet data).

Does this fix it? It's a simpler solution that would allow me to move
the other codecs than AAC to use get_buffer() instead of memcpy() in
ff_rm_retrieve_cache() also. For now, it doesn't make the demuxer more
complicated, it fixes this bug and most importantly, it eventually
(after release) allows simplification of the demuxer.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rmdec-simplfy.patch
Type: application/octet-stream
Size: 1294 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090301/00c18a3a/attachment.obj>

More information about the ffmpeg-devel mailing list