[FFmpeg-devel] [PATCH] Make RM demuxer behave better with -an option

[Michael Niedermayer]

On Mon, Mar 02, 2009 at 08:08:55PM +0200, Kostya wrote:
> On Mon, Mar 02, 2009 at 10:15:00AM -0500, Ronald S. Bultje wrote:
[...]
> > > synchronizing to
> > > the next packet header and actual packet parsing could be merged into one and
> > > put into loop like:
> > > ?for(;;){
> > > ?if(have_cached_audio)
> > > ? return ff_read_cache();
> > > ?if(parse_packet())
> > > ? return 0;
> > > ?}
> > >
> > > parse_packet(){
> > > ?if(!partial_packet)
> > > ?sync_to_next_packet_header();
> > > ?if(video)
> > > ?assemble_video_frame();
> > > ?else if(braindead_audio)
> > > ?assemble_audio_frame();
> > > ?else
> > > ?read this packet and return it
> > > }
> > >
> > > assemble_audio_frame(){
> > > ?for(i = 0; i < ast->subpackets_in_packet; i++)
> > > ?get_buffer(ast->pkt->data + subpacket_size * (i * A + ast->packet_num * B), subpacket_size);
> > > ?ast->packet_num++;
> > > }
> > 
> > I'll try to work out and see which loops are easy to merge without
> > causing other headaches. Help is appreciated. :-).
> 
> It would be nice to have a maintainer for rmdec.c and I'll try to help you anyway.

the important part is that that maintainer understands rmdec and doesnt
just rewrite it _because_ he does not understand it ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090302/b9243ff4/attachment.pgp>