[FFmpeg-devel] Request for review

[Roman V. Shaposhnik]

Well, since nobody's eager to educate me on the finer
points of rate distortion, here's a practical patch
that needs reviewing. ;-)

The objective of this patch is to reduce the number
of static tables. weigting table is left in place,
but the unweighting table gets calculated from it
instead of being statically defined.

For the DVCPRO HD the formula gives an identical result.
For everything else I ran an attached script and got
identical PSNR and STDDEV. Here's the output
for a single generation:

stddev:    0.44 PSNR: 55.15 bytes:186624000/186624000
stddev:    0.44 PSNR: 55.15 bytes:186624000/186624000
stddev:    0.40 PSNR: 55.99 bytes:186624000/186624000
stddev:    0.40 PSNR: 55.99 bytes:186624000/186624000
stddev:    0.46 PSNR: 54.74 bytes:186624000/186624000
stddev:    0.46 PSNR: 54.74 bytes:186624000/186624000
stddev:    0.49 PSNR: 54.27 bytes:186624000/186624000
stddev:    0.49 PSNR: 54.27 bytes:186624000/186624000
stddev:    0.51 PSNR: 53.96 bytes:186624000/186624000
stddev:    0.51 PSNR: 53.96 bytes:186624000/186624000
stddev:    0.50 PSNR: 54.12 bytes: 95178240/ 95178240
stddev:    0.50 PSNR: 54.12 bytes: 95178240/ 95178240
stddev:    0.80 PSNR: 50.04 bytes:155520000/155520000
stddev:    0.80 PSNR: 50.04 bytes:155520000/155520000

Please let me know if there's anything else I should
do, or whether it would be ok to commit the changes.

Thanks,
Roman.

P.S. And the video files themselves are from here:
   http://media.xiph.org/video/derf/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: regression.sh
Type: application/x-shellscript
Size: 758 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090302/25ecf088/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvtables.diff
Type: text/x-patch
Size: 7759 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090302/25ecf088/attachment-0001.bin>