[FFmpeg-devel] [PATCH] Add hwaccel_data infrastructure (take 2)

Gwenole Beauchesne gbeauchesne
Fri Mar 6 11:00:30 CET 2009


On Thu, 5 Mar 2009, Michael Niedermayer wrote:

>> However, for VDPAU, I am not sure there is another place than a ::close()
>> to destroy the bitstreamBuffers, unless they are copied locally in
>> vdp_decoder_render(). IIRC, this is asynchronous so if we delete them
>> straight away, some weird things could happen when the function comes to
>> actually need them later. ;-)
> i suggest to rename close to hwaccel_priv_close

Finally, I dropped it altogether. Stephen confirmed for the 
bitstreamBuffers structs are copied locally and ff_draw_horiz_band() will 
always call their draw_slice() with the current_picture, so it's also safe 
to release that in end_frame().

VDPAU is finally the 3rd API not strictly needing that 
hwaccel_priv_close() function so this confirms my intention to drop it.

Besides, I also dropped hwaccel_data, it's not a real gain. I am fine with 

New patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.data.private.patch
Type: text/x-diff
Size: 2451 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090306/2130042f/attachment.patch>

More information about the ffmpeg-devel mailing list