[FFmpeg-devel] [PATCH] rtsp.c: keep-alive

[Luca Barbato]

Ronald S. Bultje wrote:
> Hi again,
> 
> On Fri, Mar 6, 2009 at 8:25 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> Feng / Darwin yet untested, any fancy test-sites you recommend for DSS?
> 
> My preliminary impression is that Darwin needs no special treatment
> above the normal RTCP (UDP), and nothing at all for TCP (which is how
> it should be), so as always Apple appears to be closest to
> standard-compliance. My patch above already does everything correctly
> for Apple, so let's continue our review there.

Good =)

> Oh, btw, in a totally unrelated note, I've found DSS to stream
> "MPEG4-GENERIC" AAC instead of "mpeg4-generic" (notice case), so we
> should make the strcmp() on line 128 in rtsp.c to a strcasecmp()? Or
> maybe add a separate dynamic loader (similar to MPEG4-GENERIC) for the
> lowercase one.

 From rfc2327

"
    An SDP session description consists of a number of lines of text of
    the form <type>=<value> <type> is always exactly one character and is
    case-significant. <value> is a structured text string whose format
    depends on <type>. It also will be case-significant unless a
    specific field defines otherwise.
"

rtpmap and fmtp values are case insensitive (I don't have the reference 
handy but I'm pretty sure it's this way since I put a note about it in 
rfc5215)

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero