[FFmpeg-devel] [RFC] TwinVQ decoder

[Michael Niedermayer]

On Sat, Mar 07, 2009 at 01:54:28PM -0800, Baptiste Coudurier wrote:
> Hi,
> 
> On 3/7/2009 10:45 AM, Diego Biurrun wrote:
> > On Sat, Mar 07, 2009 at 05:47:51PM +0100, Vitor Sessak wrote:
> >> This code is still not review-quality, but any comment is welcome.
> >>
> >> /**
> >>  * Parameters and tables that are different for each frame type
> >>  */
> >> typedef struct {
> >>     uint8_t   sub;
> >>     const uint16_t *crb_tbl;
> >>     uint8_t   n_crb;
> >>     const float *fw_cb;
> >>     uint8_t   fw_n_div;
> >>     uint8_t   fw_n_bit;
> >>     const float *cb0;
> >>     const float *cb1;
> >>     uint8_t   cb_len_read;
> >> } FrameMode;
> > 
> > This would be more readable aligned.
> > 
> >> typedef struct {
> >>     const FrameMode fmode[3];
> >>
> >>     uint16_t  n_fr;
> >>     uint8_t   n_pr;
> >>     const float *lspcodebook;
> >>     uint8_t   lsp_bit0;
> >>     uint8_t   lsp_bit1;
> >>     uint8_t   lsp_bit2;
> >>     uint8_t   lsp_split;
> >>     const float *pit_cb;
> >>     uint8_t   basf_bit;
> >>     uint8_t   pit_n_bit;
> >>     uint8_t   pit_cb_len;
> >>     uint8_t   pgain_bit;
> >> } ModeTab;
> > 
> > I don't like typedefs :)
> 
> I do like typedefs :)

So do I.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090307/996e4321/attachment.pgp>