[FFmpeg-devel] [PATCH] install aes.h, des.h and rc4.h
Sun Mar 8 23:29:07 CET 2009
On Sun, Mar 08, 2009 at 09:27:12PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Sun, Mar 08, 2009 at 08:24:43PM +0100, Reimar D?ffinger wrote:
> >> On Sun, Mar 08, 2009 at 07:19:55PM +0100, Michael Niedermayer wrote:
> >> > On Sun, Mar 08, 2009 at 09:38:33AM +0100, Reimar D?ffinger wrote:
> >> > > Is there a way we can go forwards with this or should we just give up on
> >> > > making this public API.
> >> >
> >> > Where was the problem with just saying in the docs that the struct must be
> >> > aligned so that all user level instructions on the platform can access it.
> >> > Or for portable applications align by 16 byte
> >> > or something similar
> >> > ?
> >> We also need an implementation of it that works fine for asfcrypt.c.
> >> Or in other words, coming up with a public API is not enough, we must
> >> also come up with a way to actually use it within FFmpeg.
> >> Which is not really a problem since I don't mind if the structure of
> >> AVDES/AVRC4 is public and AVAES is always on the heap so far, it
> >> just seems bad to be inconsistent with AVAES and to have no concept of
> >> how to allocate AVAES on the stack (unless we decide there is never any
> >> need to allocate them on the stack).
> > what is the problem with DECLARE_ALIGNED() ?
> That it doesn't work reliably for alignment greater than 8.
So you suggest we should pick a more complex API that includes gcc bug
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel