[FFmpeg-devel] [PATCH] rmdec.c: merge old/new packet reading code
Wed Mar 11 06:46:41 CET 2009
On Wed, Mar 11, 2009 at 12:39:41AM -0400, Ronald S. Bultje wrote:
> On Tue, Mar 10, 2009 at 6:46 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > It appears seq is an ancient leftover of something that was at some
> > point correct keyframe-only index-generation. I'd suggest to throw out
> > my initial patch to remove it, I'm working on a better scheme that
> > should suffice in creating and generating indexes for index-less
> > files.
> See attached, it's sort of a poor-mans attempt but there's a lot of
> hooks and strings to it if you want it to work correctly. Comment at
> the bottom should speak for itself, the index is now written for the
> first packet of keyframes (video) or audio, or any audio packet for
> AAC/AC3 (where there's no such thing as packet-spreading of samples).
> I have another patch that reads indexes from files, I'll submit that shortly.
Somehow this becomes more and more complicated.
Can we use some simpler solution - like when packet flags & 2 and there was
no remaining_len before it (i.e. we are not inside partial packet)
nor after it (i.e. we were not reading start of partial packet, but maybe
this condition can be omitted) then add this packet to index.
Passing two additional arguments for getting data to index does not seem right.
More information about the ffmpeg-devel