[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 9)
Thu Mar 12 12:31:34 CET 2009
On Thu, Mar 12, 2009 at 06:09:08AM +0100, Gwenole Beauchesne wrote:
> Le 12 mars 09 ? 01:27, Michael Niedermayer a ?crit :
> >> + slice_param->slice_data_size = size;
> >> + slice_param->slice_data_offset = p->slice_data_size;
> >> + slice_param->slice_data_flag = VA_SLICE_DATA_FLAG_ALL;
> > extra useless whitespace
> Oh, it's great, you are now focusing on cosmetics, so this means the
> rest is correct!
There is a pattern emerging here: You get a multitude of comments, some
of them minor in nature, you use the minor comments as a pretext to
flame. However, the time you waste flaming exceeds the time it takes
to adjust those minor nits.
To sum it up: We've heard it all before, we already didn't care the
first time around.
More information about the ffmpeg-devel