[FFmpeg-devel] [PATCH] rmdec.c: parse INDX chunk
Fri Mar 13 14:52:10 CET 2009
On Fri, Mar 13, 2009 at 09:40:41AM -0400, Ronald S. Bultje wrote:
> On Wed, Mar 11, 2009 at 3:54 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Wed, Mar 11, 2009 at 2:55 PM, Kostya <kostya.shishkov at gmail.com> wrote:
> >> Run seektest first, it no regressions - very good.
> >> If some values got changed - better understand why and update seek.ref
> >> or redo the patch in case of bad values (IIRC, -1 instead of large numbers)
> > Gotcha, will do.
> Seektest caught a nice little bug hidden inside my patch, with that
> fixed, it passed with no changes. See attached. I tried cat file.rm |
> ./ffplay pipe://0 (containing an index, which is obviously not read),
> and it worked just fine, but w/o seeking of course.
> See attached for my patch which is essentially still the same.
Since it does not disturb regressions test and look fine, then patch ok.
More information about the ffmpeg-devel