[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 9)

Diego Biurrun diego
Fri Mar 13 16:46:36 CET 2009

On Thu, Mar 12, 2009 at 01:14:59PM +0100, Gwenole Beauchesne wrote:
> On Thu, 12 Mar 2009, Diego Biurrun wrote:
> >On Thu, Mar 12, 2009 at 06:09:08AM +0100, Gwenole Beauchesne wrote:
> >>Le 12 mars 09 ? 01:27, Michael Niedermayer a ?crit :
> >>
> >>>>+    slice_param->slice_data_size        = size;
> >>>>+    slice_param->slice_data_offset      = p->slice_data_size;
> >>>>+    slice_param->slice_data_flag        = VA_SLICE_DATA_FLAG_ALL;
> >>>
> >>>extra useless whitespace
> >>
> >>Oh, it's great, you are now focusing on cosmetics, so this means the
> >>rest is correct!
> >
> >There is a pattern emerging here: You get a multitude of comments, some
> >of them minor in nature, you use the minor comments as a pretext to
> >flame.  However, the time you waste flaming exceeds the time it takes
> >to adjust those minor nits.
> (i) I don't get/see a multitude of comments,

I see enough comments to your patches to warrant calling it a multitude.
The comment you took issue with was not the only thing Michael

> (ii) you are not really 
> commenting the other bits either, only the minor chunk you quoted,


> (iii) do you really want new patches when only 15 spaces, two comments
> and a few assert()'s were removed?

I never said anything to that effect, nor did I mean to imply it.

> Do the extra spaces really prevent you from seeing other problems?

So what?


More information about the ffmpeg-devel mailing list