[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 9)

Michael Niedermayer michaelni
Fri Mar 13 20:58:37 CET 2009


On Fri, Mar 13, 2009 at 05:05:06PM +0100, Gwenole Beauchesne wrote:
> Hi,
>
> On Thu, 12 Mar 2009, Michael Niedermayer wrote:
>
>> On Thu, Mar 12, 2009 at 06:09:08AM +0100, Gwenole Beauchesne wrote:
>>> Le 12 mars 09 ? 01:27, Michael Niedermayer a ?crit :
>>>
>>>>> +{
>>>>> +    const struct vaapi_context *va_context = avctx->hwaccel_context;
>>>>> +    struct vaapi_hwaccel_data_private * const p = pic-
>>>>>> hwaccel_data_private;
>>>>
>>>> the structs should be named in a way that makes it obvious which is
>>>> "global" and which is per frame like
>>>> hwaccel_frame/surface/..._private or so
>>>
>>> The current names are obvious.
>>> - vaapi_context derived from and accessed from
>>> AVCodecContext.hwaccel_context
>>
>>> - vaapi_hwaccel_data_private derived from and accessed from
>>> Picture.hwaccel_data_private
>>
>> both are bad, both should be changed
>
> Please elaborate, they looked very intuitive and straightforward.
>
> Anyway, here are some other random names, just pick one that suits you 
> best...
>

> - vaapi_context:

that can be kept


>
> - vaapi_hwaccel_data_private:

> vaapi_frame_private
> vaapi_picture_private
[...]
> vaapi_surface_private

these 3 are ok for me, pick what you prefer

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090313/3f14ae90/attachment.pgp>



More information about the ffmpeg-devel mailing list