[FFmpeg-devel] [PATCH] fix pcm_read_seek with negative timestamp
Sat Mar 14 18:35:08 CET 2009
On Sat, Mar 14, 2009 at 06:26:07PM +0100, Reimar D?ffinger wrote:
> On Sat, Mar 14, 2009 at 05:55:43PM +0100, Michael Niedermayer wrote:
> > > > which breaks the API
> > > > now, seek2() fixes all that by introducing an API that has no problem
> > > > with timestamps that are outside the first..last
> > >
> > > I can't find anything in the avformat.h description of av_seek_frame or
> > > read_seek which would explain why this should break API, could you be
> > > more specific?
> > yes, the flags select direction, if you ask for lets say ts=-123 and
> > backward and it succeeds with ts=0 (which is not backward) thats just
> > not strictly correct.
> According to the documentation in avformat.h it is correct:
> read_seek doxy: "Selects which direction should be preferred"
> Admittedly av_seek_frame doxy is unclear...
ahh, ok, if it says " preferred" then patch ok
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The educated differ from the uneducated as much as the living from the
dead. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel