[FFmpeg-devel] [PATCH] Implement AVPixFmtDescriptor.name

[Michael Niedermayer]

On Sun, Mar 15, 2009 at 11:53:05AM +0100, Stefano Sabatini wrote:
> On date Sunday 2009-03-15 02:04:26 +0100, Michael Niedermayer encoded:
> > On Sun, Mar 15, 2009 at 12:50:15AM +0100, Stefano Sabatini wrote:
> > > Hi,
> > > 
> > > as in subject.
> > [...]
> > > Index: ffmpeg/libavcodec/pixdesc.h
> > > ===================================================================
> > > --- ffmpeg.orig/libavcodec/pixdesc.h	2009-03-15 00:43:36.000000000 +0100
> > > +++ ffmpeg/libavcodec/pixdesc.h	2009-03-15 00:43:53.000000000 +0100
> > > @@ -41,6 +41,7 @@
> > >   *       are stored not what these values represent.
> > >   */
> > >  typedef struct AVPixFmtDescriptor{
> > > +    const char *name;
> > 
> > const char name[10];
> 
> I feel uncomfortable with just 10 chars, what about to raise that size
> to 16 or more?

with 16 we can just keep the pointer


> 
> Then we won't need bump in case of some overly long pixfmts, and we
> have *already* pixfmt names which can't be contained in 10 chars
> ("vaapi_moco").

rename to vapi_mc

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090315/75d69377/attachment.pgp>