[FFmpeg-devel] [PATCH] Fix confusing assert in lzwenc.c

Benoit Fouet benoit.fouet
Mon Mar 16 13:47:39 CET 2009


On 03/15/2009 05:25 AM, Michael Niedermayer wrote:
> On Sun, Feb 08, 2009 at 11:42:23PM -0600, Daniel Verkamp wrote:
>   
>> Hi,
>>
>> Attached fixes an assert in libavcodec/lzwenc.c:
>>
>> 1. The right side of the && made no sense at all - comparing
>> s->maxbits with itself?  Presumably this should be LZW_MAXBITS as in
>> patch.
>> 2. The left side of the && was confusing (to me at least) because of
>> the order in which it was written, although both forms are equivalent.
>>
>> Thanks,
>> -- Daniel Verkamp
>>     
>
>   
>> From 7a56c9f0b664b59a9a18c33c88205c702c9ef3ce Mon Sep 17 00:00:00 2001
>> From: Daniel Verkamp <daniel at drv.nu>
>> Date: Sun, 8 Feb 2009 23:39:32 -0600
>> Subject: [PATCH] Fix confusing assert
>>     
>
> ok
>
> [...]
>   
>   

applied

Ben




More information about the ffmpeg-devel mailing list