[FFmpeg-devel] [PATCH] more mov edl fixes

[Baptiste Coudurier]

On 3/16/2009 12:58 PM, Reimar D?ffinger wrote:
> On Mon, Mar 16, 2009 at 11:55:28AM -0700, Baptiste Coudurier wrote:
>> Are you sure the rescaling is right for "time" ? "time" should be in
>> track timescale, while duration is in movie timescale IIRC.
> 
> Right, so what is the least ugly solution? A extra field for this?
> Or like this patch:

Not sure, I like your solution.

> Index: libavformat/mov.c
> ===================================================================
> --- libavformat/mov.c	(revision 18017)
> +++ libavformat/mov.c	(working copy)
> @@ -1278,8 +1278,9 @@
>  
>      /* adjust first dts according to edit list */
>      if (sc->time_offset) {
> +        int rescaled = sc->time_offset < 0 ?  av_rescale(sc->time_offset, sc->time_scale, mov->time_scale) : sc->time_offset;

Extra space after '?' it seems.

int time; can now be merged with code I think. I'll change it after.

Patch seems ok :)

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org