[FFmpeg-devel] rmdec.c: add SIPR codec try #2
Ronald S. Bultje
Tue Mar 17 21:15:19 CET 2009
On Tue, Mar 17, 2009 at 3:56 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Tue, Mar 17, 2009 at 03:45:51PM -0400, Ronald S. Bultje wrote:
>> On Tue, Mar 17, 2009 at 3:21 PM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>> > That's simply wrong, for the ((i ^ o) & 1) case you will alternate
>> > between i & 1 and not, so you can't move that check out of the loop.
>> Well, I calculate the mask per iteration so then it's OK (right?). The
>> end result was identical to original code.
> If the inner part of the loop works for both even and odd i you wouldn't
> need the second if, that much is sure.
First if: i&1 and o&1, or !(i&1) and !(o&1)
Second if: i&1 and !(o&1)
Last (else): !(i&1) and o&1
More information about the ffmpeg-devel