[FFmpeg-devel] MXF D10 regression tests

Michael Niedermayer michaelni
Wed Mar 18 14:31:33 CET 2009

On Wed, Mar 18, 2009 at 02:20:43PM +0100, Reimar D?ffinger wrote:
> On Wed, Mar 18, 2009 at 01:44:03PM +0100, Michael Niedermayer wrote:
> > It is not supposed to be a restriction for avcodec_encode_video() though
> > maybe it is by a bug. (i did not test this)
> > The restriction is just on the internal buffers, which for encoding are
> > allocated by lavc.
> Oh, ok. Then attached patch can fix this simpler and more thoroughly (it
> seems to fix both intra and inter 4:2:2 encoding on PPC).
> Note it may still contain some brainfarts, 

> it still feels a bit
> confusing and suboptimal to me currently.

to me too

> @@ -243,7 +243,7 @@
>          int size[4] = {0};
>          int tmpsize;
>          AVPicture picture;
> -        int stride_align[4];
> +        int stride_align = STRIDE_ALIGN;
>          avcodec_get_chroma_sub_sample(s->pix_fmt, &h_chroma_shift, &v_chroma_shift);

this is conceptually slightly bad because
16x16 MBs in luma may need 16 byte alignment and
8x8 MBs in 420 chroma may need 8 byte alignment

wile SVQ1 needs 16byte alignment in both due to having 16x16 in both


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090318/0d76aae8/attachment.pgp>

More information about the ffmpeg-devel mailing list