[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 13A -- alternate)

Gwenole Beauchesne gbeauchesne
Fri Mar 20 15:55:40 CET 2009


On Fri, 20 Mar 2009, Michael Niedermayer wrote:

> anyway the rest of the patch looks ok, you can commit it after
> fixing these 2, but note, iam not 100% happy about the read only
> context vs putting local vars in each Pic

OK, here is an alternate version with vaapi_context only, i.e. 
vaapi_picture_private is nuked away. It turned out MPEG-4 was the only 
location I needed pic_param, but I noticed AVFrame had a pict_type copy. 
Is it guaranteed to be the old s->pict_type?

Really, I don't really like that approach, but it's a matter of taste I 
believe. ;-) Reminder: vaapi.h is a public (installed) header and exposing 
internal data doesn't really look sane to me.

Anyway, I sent you both versions, just decide.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.common.13.alternate.patch
Type: text/x-diff
Size: 13078 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090320/885c75f8/attachment.patch>

More information about the ffmpeg-devel mailing list