[FFmpeg-devel] [PATCH] get rid of nonsense palette pointer for RGB8, GRAY8 etc.

Michael Niedermayer michaelni
Fri Mar 20 21:12:49 CET 2009

On Fri, Mar 20, 2009 at 08:30:38PM +0100, Reimar D?ffinger wrote:
> On Fri, Mar 20, 2009 at 07:42:47PM +0100, Michael Niedermayer wrote:
> > removing the palette for gray8 will require a special case in all paletted
> > encoders. I think this is worse than fixing whatever failed to set the
> > palette
> Haven't found that code yet, but I suspect it may already be correct and
> the palette was only not copied by rawenc.c, so I won't bother with it
> further.
> > the code that dumps it into a raw file
> See attached. Haven't found documentation for avpicture_layout though.
> It also misses the regression test updates, because currently the
> regressions tests for me create the file b-libav-gray.yuv with size 0,
> but if I run the command manually it has the correct size of 304128...
> For no particular reason I am also a bit suspicious if that
> avpicture_layout function works correctly for the alpha formats...

> About fixing the swscale planarCopy, are you fine with this ugly hack (I
> assume there is no need to "reset" the GRAY8 palette data in dst):

no, sws_scale() passes dst through and this would end up changing the
users dst[] i think
(also the palette handling in sws_scale() can probably be simplified by
 droping all but the PAL8 code)

about the avpicture_layout patch i dont understand it, avpicture_get_size()
should return the correct size

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090320/fd2b5929/attachment.pgp>

More information about the ffmpeg-devel mailing list