[FFmpeg-devel] [RFC] Split libswscale's yuv2rgb per dir.
Fri Mar 20 23:56:15 CET 2009
On Fri, Mar 20, 2009 at 03:46:40PM -0300, Ramiro Polla wrote:
> On Fri, Mar 20, 2009 at 12:22 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Mar 19, 2009 at 06:20:32PM -0300, Ramiro Polla wrote:
> >> Hi,
> >> Attached patches are a first step at splitting libswscale into dirs.
> >> It only does yuv2rgb for now. Tested for C, MMX and Altivec. I haven't
> >> tested for blackfin but I should be able to test it some time next
> >> week if someone doesn't do it first. I can't test sparc and mlib
> >> beyond compiling.
> >> rgb2rgb and swscale are scary, so I wanted to make sure this is the
> >> correct way of doing things before working longer on them.
> >> When all the split is done the swscale code should be cleaner and
> >> easier to understand, and the files should have a less monstrous size
> >> (resulting in a couple more files, obviously).
> >> Attached patch is applied after:
> >> # ? ? ? renamed: ? ?yuv2rgb_bfin.c -> bfin/yuv2rgb_bfin.c
> >> # ? ? ? renamed: ? ?yuv2rgb_mlib.c -> mlib/yuv2rgb_mlib.c
> >> # ? ? ? renamed: ? ?yuv2rgb_altivec.c -> ppc/yuv2rgb_altivec.c
> >> # ? ? ? renamed: ? ?yuv2rgb_vis.c -> sparc/yuv2rgb_vis.c
> >> # ? ? ? new file: ? x86/yuv2rgb_mmx.c (copied from yuv2rgb.c)
> >> # ? ? ? renamed: ? ?yuv2rgb_template.c -> x86/yuv2rgb_template.c
> >> Ramiro Polla
> > is your patch missing the diff for yuv2rgb_mmx.c ?
> Yes. I got beaten by git.
i suggest to commit the yuv2rgb cleanup before working on sws
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel